Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in dubbo #3937

Merged
merged 2 commits into from
Apr 26, 2019
Merged

fix typo in dubbo #3937

merged 2 commits into from
Apr 26, 2019

Conversation

Moriadry-zz
Copy link

What is the purpose of the change

fix #3933

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@Moriadry-zz
Copy link
Author

Still many typos to be fixed, hang on merge.

@codecov-io
Copy link

codecov-io commented Apr 26, 2019 •
edited
Loading

Codecov Report

Merging #3937 into master will increase coverage by 0.34%.
The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #3937      +/-   ##
===========================================
+ Coverage     63.66%     64%   +0.34%     
  Complexity       71      71              
===========================================
  Files           713     713              
  Lines         31460   32006     +546     
  Branches       5070    5256     +186     
===========================================
+ Hits          20028   20485     +457     
- Misses         9138    9195      +57     
- Partials       2294    2326      +32
Impacted Files Coverage Δ Complexity Δ
...pc/cluster/loadbalance/LeastActiveLoadBalance.java 88.88% <ø> (ø) 0 <0> (ø) ⬇️
...rg/apache/dubbo/rpc/protocol/AbstractProtocol.java 79.31% <ø> (ø) 0 <0> (ø) ⬇️
...ubbo/remoting/etcd/support/AbstractEtcdClient.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...pache/dubbo/remoting/transport/AbstractClient.java 67.91% <100%> (ø) 0 <0> (ø) ⬇️
...o/common/extension/AdaptiveClassCodeGenerator.java 94.87% <100%> (ø) 0 <0> (ø) ⬇️
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 64.1% <0%> (-17.95%) 0% <0%> (ø)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 67.21% <0%> (-3.28%) 0% <0%> (ø)
...g/apache/dubbo/rpc/protocol/rest/RestProtocol.java 67.96% <0%> (-3.13%) 0% <0%> (ø)
...he/dubbo/registry/multicast/MulticastRegistry.java 68.32% <0%> (-1.36%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 47.91% <0%> (+1.04%) 0% <0%> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d0c07d...dbddfbf. Read the comment docs.

@Moriadry-zz Moriadry-zz changed the title WIP: fix typo in dubbo fix typo in dubbo Apr 26, 2019
CrazyHZM
CrazyHZM approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrazyHZM
Copy link
Member

I will merge it when I pass ci.

@CrazyHZM CrazyHZM merged commit efa8332 into apache:master Apr 26, 2019
vio-lin pushed a commit to vio-lin/incubator-dubbo that referenced this pull request Apr 29, 2019
@moriadry @vio-lin
fix typo in dubbo (apache#3937)
b239402
@dubbo-bot dubbo-bot mentioned this pull request May 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CrazyHZM CrazyHZM CrazyHZM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spelling error in org.apache.dubbo.common.extension.AdaptiveClassCodeGenerator#generateReturnAndInovation
4 participants
@Moriadry-zz @codecov-io @CrazyHZM @moriadry